Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Root Cause

• DorisAlterResourceStatement redeclares databaseType, which already exists in the parent SQLStatement, creating duplicate state and potential divergence.
• Assertions only check the resource name and non-null properties, never validating property key/value parsing, so visitor errors can slip through.
• Grammar and visitor accept only string resource names and property keys/values; Doris syntax allows identifier-style keys and values beyond strings (official reference: https://doris.apache.org/docs/2.1/sql-manual/sql-statements/cluster-management/compute-management/ALTER-RESOURCE/).

Analysis

• Redundant field: the parent already holds databaseType; keeping another copy in the subclass risks inconsistency on future changes/serialization.
• Assertion gap: DorisAlterResourceStatementAssert doesn’t verify property key/values, so misparsed or missing properties still pass.
• Syntax/visitor coverage: official syntax shows ALTER RESOURCE '<resource_name>' PROPERTIES(\key = value, ...), where the key is an identifier (backticked) and the value is not restricted to strings. The current rule using only string_ would reject valid statements with unquoted identifiers or non-string values.

Conclusion (Change Request)

• Remove the duplicate databaseType field and assignment in DorisAlterResourceStatement; rely on the parent field. Keep constructor calling super(databaseType) and storing only resourceName and properties:

  public final class DorisAlterResourceStatement extends DALStatement {
      private final String resourceName;
      private final Properties properties;

      public DorisAlterResourceStatement(final DatabaseType databaseType, final String resourceName, final Properties properties) {
          super(databaseType);
          this.resourceName = resourceName;
          this.properties = properties;
      }
  }

• Strengthen assertions: add expected property key/values in test cases (e.g., list or map) and validate size plus specific key/values in DorisAlterResourceStatementAssert to ensure visitor parsing is correct.
• Align grammar and visitor with the official doc: allow resource names/property keys as identifiers or strings, and property values as literals (string/number/boolean). Update the visitor to handle IdentifierValue, StringLiteralValue, NumberLiteralValue, and booleans accordingly, and add SQL cases plus assertions covering these forms. After these adjustments, merging will be safer.

Here’s what needs to be fixed before we can merge—thanks for the solid start, please keep going:

• parser/sql/engine/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/engine/doris/visitor/statement/type/DorisDALStatementVisitor.java:909: getPropertyValue only handles string/number literals; boolean/NULL/hex/etc. fall through to result.toString(), so
  those property values are parsed as object ids, not the literal values. Please decode all LiteralValue types (BooleanLiteralValue, NullLiteralValue, hex/bit, etc.) via getValue(), mirroring other dialect handlers.
• Tests: test/it/parser/src/main/resources/case/dal/alter.xml and .../sql/supported/dal/alter.xml only cover string/number properties. Add cases for boolean/NULL (and other literal forms) to exercise the fixed paths.

Once these are addressed, the PR should be in good shape to re-review.

Nice work on the comprehensive coverage and tidy wiring—thanks for the thorough contribution!